Remove behaviour forcing types to be first in exports

Author: cefn

index.js

@@ -390,27 +390,21 @@ const sortScripts = onObject((scripts, packageJson) => {
 })
 
 /*
-- Move `types` and versioned type condition to top
 - Move `default` condition to bottom
 */
 const sortConditions = (conditions) => {
-  const {
-    typesConditions = [],
-    defaultConditions = [],
-    restConditions = [],
-  } = objectGroupBy(conditions, (condition) => {
-    if (condition === 'types' || condition.startsWith('types@')) {
-      return 'typesConditions'
-    }
-
-    if (condition === 'default') {
-      return 'defaultConditions'
-    }
+  const { defaultConditions = [], restConditions = [] } = objectGroupBy(
+    conditions,
+    (condition) => {
+      if (condition === 'default') {
+        return 'defaultConditions'
+      }
 
-    return 'restConditions'
-  })
+      return 'restConditions'
+    },
+  )
 
-  return [...typesConditions, ...restConditions, ...defaultConditions]
+  return [...restConditions, ...defaultConditions]
 }
 
 const sortExports = onObject((exports) => {

tests/exports.js

@@ -4,40 +4,6 @@ import { macro } from './_helpers.js'
 for (const deep of [false, true]) {
   const titleSuffix = deep ? `(deep)` : ''
 
-  {
-    const exports = {
-      unknown: './unknown.unknown',
-      './path-not-really-makes-no-sense': {},
-      types: './types.d.ts',
-      'types@<=1': './v1/types.d.ts',
-    }
-
-    test(`'types' condition should be first${titleSuffix}`, macro.sortObject, {
-      path: 'exports',
-      expect: 'snapshot',
-      value: deep ? { './deep': exports } : exports,
-    })
-  }
-
-  {
-    const exports = {
-      unknown: './unknown.unknown',
-      './path-not-really-makes-no-sense': {},
-      'types@<=1': './v1/types.d.ts',
-      types: './types.d.ts',
-    }
-
-    test(
-      `'types' condition should be first${titleSuffix} 2`,
-      macro.sortObject,
-      {
-        path: 'exports',
-        expect: 'snapshot',
-        value: deep ? { './deep': exports } : exports,
-      },
-    )
-  }
-
   {
     const exports = {
       unknown: './unknown.unknown',

tests/snapshots/exports.js.md

@@ -4,56 +4,6 @@ The actual snapshot is saved in `exports.js.snap`.
 
 Generated by [AVA](https://avajs.dev).
 
-## 'types' condition should be first
-
-> Should sort `exports` as object.
-
-    {
-      input: `{␊
-        "exports": {␊
-          "unknown": "./unknown.unknown",␊
-          "./path-not-really-makes-no-sense": {},␊
-          "types": "./types.d.ts",␊
-          "types@<=1": "./v1/types.d.ts"␊
-        }␊
-      }`,
-      options: undefined,
-      output: `{␊
-        "exports": {␊
-          "./path-not-really-makes-no-sense": {},␊
-          "types": "./types.d.ts",␊
-          "types@<=1": "./v1/types.d.ts",␊
-          "unknown": "./unknown.unknown"␊
-        }␊
-      }`,
-      pretty: true,
-    }
-
-## 'types' condition should be first 2
-
-> Should sort `exports` as object.
-
-    {
-      input: `{␊
-        "exports": {␊
-          "unknown": "./unknown.unknown",␊
-          "./path-not-really-makes-no-sense": {},␊
-          "types@<=1": "./v1/types.d.ts",␊
-          "types": "./types.d.ts"␊
-        }␊
-      }`,
-      options: undefined,
-      output: `{␊
-        "exports": {␊
-          "./path-not-really-makes-no-sense": {},␊
-          "types@<=1": "./v1/types.d.ts",␊
-          "types": "./types.d.ts",␊
-          "unknown": "./unknown.unknown"␊
-        }␊
-      }`,
-      pretty: true,
-    }
-
 ## 'default' condition should be last
 
 > Should sort `exports` as object.
@@ -77,64 +27,6 @@ Generated by [AVA](https://avajs.dev).
       pretty: true,
     }
 
-## 'types' condition should be first(deep)
-
-> Should sort `exports` as object.
-
-    {
-      input: `{␊
-        "exports": {␊
-          "./deep": {␊
-            "unknown": "./unknown.unknown",␊
-            "./path-not-really-makes-no-sense": {},␊
-            "types": "./types.d.ts",␊
-            "types@<=1": "./v1/types.d.ts"␊
-          }␊
-        }␊
-      }`,
-      options: undefined,
-      output: `{␊
-        "exports": {␊
-          "./deep": {␊
-            "./path-not-really-makes-no-sense": {},␊
-            "types": "./types.d.ts",␊
-            "types@<=1": "./v1/types.d.ts",␊
-            "unknown": "./unknown.unknown"␊
-          }␊
-        }␊
-      }`,
-      pretty: true,
-    }
-
-## 'types' condition should be first(deep) 2
-
-> Should sort `exports` as object.
-
-    {
-      input: `{␊
-        "exports": {␊
-          "./deep": {␊
-            "unknown": "./unknown.unknown",␊
-            "./path-not-really-makes-no-sense": {},␊
-            "types@<=1": "./v1/types.d.ts",␊
-            "types": "./types.d.ts"␊
-          }␊
-        }␊
-      }`,
-      options: undefined,
-      output: `{␊
-        "exports": {␊
-          "./deep": {␊
-            "./path-not-really-makes-no-sense": {},␊
-            "types@<=1": "./v1/types.d.ts",␊
-            "types": "./types.d.ts",␊
-            "unknown": "./unknown.unknown"␊
-          }␊
-        }␊
-      }`,
-      pretty: true,
-    }
-
 ## 'default' condition should be last(deep)
 
 > Should sort `exports` as object.