Support tearing off tags menu #11652
Conversation
droidmonkey
added
feature: Tags
pr: new feature
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #11652 +/- ##
===========================================
- Coverage 63.69% 63.68% -0.00%
===========================================
Files 366 366
Lines 38513 38527 +14
===========================================
+ Hits 24528 24535 +7
- Misses 13985 13992 +7 ☔ View full report in Codecov by Sentry. |
droidmonkey
force-pushed
the
feature/tags-tearoff
branch
from
d8d003c to
bcb0437
Compare
|
@droidmonkey, In Linux, clicking on a tag from the context menu results in a segmentation fault. |
|
I'm also having |
| if (!databaseUnlocked) { | ||
| m_ui->menuTags->hideTearOffMenu(); | ||
| } else { | ||
| updateSetTagsMenu(); |
There was a problem hiding this comment.
If you remove this line, everything works just fine. I think this function is already called via signal/slot in line 257?
There was a problem hiding this comment.
This line is necessary to update the tags list when you change your entry selection choices. Saw no crashes on Windows so that's weird.
There was a problem hiding this comment.
Found the problem, please re-test on your end
There was a problem hiding this comment.
I tested it, it works without errors
There was a problem hiding this comment.
Still crashes for me. Sometimes the tearoff menu works, sometimes enabling it will crash directly, sometimes setting a tag crashes:
KeePassXC[94447:7219921] IOSurface creation failed: e00002bd parentID: 00000000 properties: {
IOSurfaceAllocSize = 0;
IOSurfaceBytesPerElement = 4;
IOSurfaceBytesPerRow = 0;
IOSurfaceHeight = 0;
IOSurfaceName = "libqcocoa.dylib";
IOSurfacePixelFormat = 1111970369;
IOSurfaceWidth = 0;
}
KeePassXC[94447:7219921] IOSurface creation failed: e00002bd parentID: 00000000 property: IOSurfaceWidth
KeePassXC[94447:7219921] IOSurface creation failed: e00002bd parentID: 00000000 property: IOSurfaceBytesPerElementKeePassXC[94447:7219921] IOSurface creation failed: e00002bd parentID: 00000000 property: IOSurfacePixelFormat
KeePassXC[94447:7219921] IOSurface creation failed: e00002bd parentID: 00000000 property: IOSurfaceBytesPerRow
KeePassXC[94447:7219921] IOSurface creation failed: e00002bd parentID: 00000000 property: IOSurfaceHeight
KeePassXC[94447:7219921] IOSurface creation failed: e00002bd parentID: 00000000 property: IOSurfaceAllocSize
KeePassXC[94447:7219921] IOSurface creation failed: e00002bd parentID: 00000000 property: IOSurfaceName
KeePassXC[94447:7219921] [qt.qpa.backingstore.iosurface] Failed to lock QIOSurfaceGraphicsBuffer(0x6000011e9c80, surface=0x0, size=QSize(0, 0), isLocked=false, isInUse=false) -536870206
Exception: EXC_BREAKPOINT (code=1, subcode=0x19c67cdcc)
There was a problem hiding this comment.
There seems to be a major bug in qt5 macos when it comes to tear off menus.
* Closes #11649 - tags menu can be torn off to set and unset tags without having to dive into the context menu every time. * Tags menu will hide when database is locked or view is switched away from the main database view (eg, settings)
droidmonkey
force-pushed
the
feature/tags-tearoff
branch
from
bcb0437 to
b946aca
Compare
Closes Tags multiselect right click context menu #11649 - tags menu can be torn off to set and unset tags without having to dive into the context menu every time.
Tags menu will hide when database is locked or view is switched away from the main database view (eg, settings)
Screenshots
See #11649
Testing strategy
Tested on windows manually
Type of change