Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.8.0-snapshot - Missing translations in Settings - Shortcuts #10335

Open
Stephan-P opened this issue Feb 26, 2024 · 4 comments · May be fixed by #11154
Open

2.8.0-snapshot - Missing translations in Settings - Shortcuts #10335

Stephan-P opened this issue Feb 26, 2024 · 4 comments · May be fixed by #11154
Assignees
@droidmonkey
Labels
PRE-RELEASE BUG

Comments

@Stephan-P
Copy link

Missing translations in Settings - Shortcuts

I did export the latest .ts translation from Transifex, used QT-Linguist to release this into a .qm and copied the .qm into the translations folder. Also these three strings have been properly translated in Transifex Develop. So my guess is that these strings are not yet referenced with translations.

image

Debug info:
KeePassXC - Version 2.8.0-snapshot
Build Type: Snapshot
Revision: a472ef8

Qt 5.15.12
Debugging mode is disabled.

Operating system: Windows 11 Version 2009
CPU architecture: x86_64
Kernel: winnt 10.0.22631

Enabled extensions:

  • Automatisch invullen
  • Browserintegratie
  • Passkeys
  • SSH-agent
  • KeeShare
  • YubiKey
  • Snel ontgrendelen

Cryptographic libraries:

  • Botan 3.1.1
@droidmonkey droidmonkey closed this as not planned Won't fix, can't repro, duplicate, stale Feb 26, 2024
@droidmonkey droidmonkey reopened this Feb 26, 2024
@droidmonkey
Copy link
Member

These appear to be setup correctly in code: https://github.com/keepassxreboot/keepassxc/blob/develop/src%2Fgui%2FShortcutSettingsPage.cpp#L105

@Stephan-P
Copy link
Author

Stephan-P commented Feb 29, 2024 •
edited
Loading

Turkish is another language for which Transifex Develop shows 100% translation.
With UI language set to Turkish, the same three strings are presented in English.
image

(Switching back to System default language now)

@Stephan-P
Copy link
Author

Still in today's snapshot.
Missing translations in Settings - Shortcuts

After having updated Transifex Develop to 100% translated and reviewed, I performed an export of that .ts file, used QT-Linguist to release this into a .qm and copied the .qm into the KeePassXC\share\translations folder.

Again, my guess is that these strings are not properly referenced to Transifex translations.

image

Debug info:
KeePassXC - Version 2.8.0-snapshot
Build Type: Snapshot
Revision: 267928d

Qt 5.15.11
Debugging mode is disabled.

Operating system: Windows 11 Version 2009
CPU architecture: x86_64
Kernel: winnt 10.0.22631

Enabled extensions:

  • Automatisch invullen
  • Browserintegratie
  • Passkeys
  • SSH-agent
  • KeeShare
  • YubiKey
  • Snel ontgrendelen

Cryptographic libraries:

  • Botan 3.1.1

@droidmonkey
Copy link
Member

I'm working on it, can't figure out why qt doesn't pick these up

droidmonkey added a commit that referenced this issue Aug 10, 2024
@droidmonkey
Fix translations on Keyboard Shortcuts Widget
0382f6e 
* Fixes #10335
@droidmonkey droidmonkey linked a pull request Aug 10, 2024 that will close this issue
Open
droidmonkey added a commit that referenced this issue Sep 27, 2024
@droidmonkey
Fix translations on Keyboard Shortcuts Widget
4fc0e28 
* Fixes #10335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@droidmonkey droidmonkey

Labels
PRE-RELEASE BUG
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix translations on Keyboard Shortcuts Widget keepassxreboot/keepassxc
2 participants
@droidmonkey @Stephan-P