Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: Implement tests for new rpc method starknet_getTransactionStatus #1298

Closed
antiyro opened this issue Dec 6, 2023 · 5 comments · Fixed by #1610
Closed

dev: Implement tests for new rpc method starknet_getTransactionStatus #1298

antiyro opened this issue Dec 6, 2023 · 5 comments · Fixed by #1610
Assignees
@fishseabowl
Labels
backlog Ready to be picked enhancement New feature or request needed-for-mainnet

Comments

@antiyro
Copy link
Contributor

antiyro commented Dec 6, 2023

Implement tests for new rpc method starknet_getTransactionStatus

The goal of this issue is to implement tests regarding the recently implemented rpc method starknet_getTransactionStatus under starknet-rpc-tests/
@antiyro antiyro added the enhancement New feature or request label Dec 6, 2023
@antiyro antiyro mentioned this issue Dec 6, 2023
Merged
@ybensacq
Copy link
Contributor

ybensacq commented Dec 6, 2023

@antiyro can you assign it to me
Plz ?

@antiyro
Copy link
Contributor Author

antiyro commented Dec 6, 2023

Sure if you need any help please let me know!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Jan 6, 2024
@tdelabro tdelabro added backlog Ready to be picked and removed stale labels May 6, 2024
@fishseabowl
Copy link
Contributor

@tdelabro Could I take this? Thanks

@tdelabro
Copy link
Collaborator

tdelabro commented May 7, 2024

@fishseabowl sure

@fishseabowl fishseabowl mentioned this issue May 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fishseabowl fishseabowl

Labels
backlog Ready to be picked enhancement New feature or request needed-for-mainnet
Projects
Madara
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add rpc test starknet_getTransactionStatus fishseabowl/madara
5 participants
@ybensacq @fishseabowl @tdelabro @antiyro @apoorvsadana