Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM updates dependent on routes are significantly slower than manual updates to app-state #33

Open
morgancmartin opened this issue Jun 10, 2018 · 1 comment

Comments

@morgancmartin
Copy link

I have noticed that when using the ui/url workflow to update the routes and building components to be dependent on a particular route pattern, DOM updates are slowed significantly. I have attempted to use the ui/url pattern in a couple of places in my application so far and the slowdown has been noticeable in both. I am unsure if the slowdown is due to me misunderstanding the way the pattern ought to work or if it is inherent to the route-driven design of Keechma. When resorting to ui/send-command which causes a controller to update app-state manually and having the components depend on the presence of an item in the app-state rather than on the routes, that speed is improved dramatically.

I'm wondering if anyone else has experienced this or if I am perhaps doing something wrong. I can provide complete code examples upon request.

@retro
Copy link
Contributor

retro commented Jun 10, 2018

@morgancmartin we are using the url pattern in all of our apps and so far we didn't notice any visible slowdown. It will definitely be somewhat slower because of the amount of work being done, but it shouldn't be noticeable.

Please upload your example and I'll take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants