Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fallback check bug for scaleobject #6355

Closed
ctccxxd opened this issue Nov 21, 2024 · 2 comments
Closed

fallback check bug for scaleobject #6355

ctccxxd opened this issue Nov 21, 2024 · 2 comments
Labels
bug Something isn't working stale All issues that are marked as stale due to inactivity

Comments

@ctccxxd
Copy link
Contributor

ctccxxd commented Nov 21, 2024

Report

when user config a fallback part in a scaleobject, the related webhook module check take no effect. The code has been in the project main branch, but take no effect yet.
code2

Expected Behavior

When user have misconfiguration, such as invalid failureThreshold or replicas value. The webhook should not validate it.

Actual Behavior

Validate it even for invalid failureThreshold, replicas value, or invalid metric type.

Steps to Reproduce the Problem

I have contribute my code, welcome to review #6346.

Logs from KEDA operator

No

KEDA Version

main branch

Kubernetes Version

None

Platform

None

Scaler Details

No response

Anything else?

No response

Copy link

stale bot commented Jan 21, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Jan 21, 2025
Copy link

stale bot commented Jan 28, 2025

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Jan 28, 2025
@github-project-automation github-project-automation bot moved this from To Triage to Ready To Ship in Roadmap - KEDA Core Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale All issues that are marked as stale due to inactivity
Projects
Status: Ready To Ship
Development

No branches or pull requests

1 participant