Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE bugs in MaximumProductOfWordLengths.java and RemoveDuplicatesFromSortedArray.java #156

Open
HermioneSW opened this issue Apr 9, 2020 · 3 comments
Open

NPE bugs in MaximumProductOfWordLengths.java and RemoveDuplicatesFromSortedArray.java #156

HermioneSW opened this issue Apr 9, 2020 · 3 comments

Comments

@HermioneSW
Copy link

Hi,

I have found two bugs in MaximumProductOfWordLengths.java (leetcode/bit-manipulation/MaximumProductOfWordLengths.java) and RemoveDuplicatesFromSortedArray.java(leetcode/two-pointers/RemoveDuplicatesFromSortedArray.java).

In MaximumProductOfWordLengths.java line 20 if(words.length == 0 || words == null) if words is null, words.length will NPE

Similarly in RemoveDuplicatesFromSortedArray.java line 12 if(nums.length == 0 || nums == null) if nums is null then nums.length will NPE.

I know they are minor issues. I would still be good if you can fix them. Thanks a lot!
@HermioneSW
Copy link
Author

Hi, can anyone please confirm and fix those bugs? Thanks so much!

@wangpeipei90
Copy link

You need to create a pull request so the author can merge it directly.

@divyani1997
Copy link

Hi, Can I work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wangpeipei90 @divyani1997 @HermioneSW