🐛 Start informers for objects that they haven't been started for yet #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On-behalf-of: SAP <[email protected]> Signed-off-by: Marvin Beckers <[email protected]>
kcp-ci-bot
added
release-note-none
sttts
reviewed
Mar 13, 2025
examples/apiexport/main.go
Outdated
| return reconcile.Result{}, err | ||
| } | ||
|
|
||
| log.Info("Found Secret objects in Workspace of ConfigMap", "count", len(secrets.Items)) |
Member
There was a problem hiding this comment.
I don't like this here in the example. We need e2e tests.
Member
Author
There was a problem hiding this comment.
I agree. I can remove it from the example, I just needed a way to validate it. With the sdk changes to include a testing framework, we can write e2e tests.
On-behalf-of: SAP <[email protected]> Signed-off-by: Marvin Beckers <[email protected]>
Member
|
From now on, after this PR, we need tests. |
sttts
approved these changes
Mar 16, 2025
Contributor
|
LGTM label has been added. Git tree hash: 5d934ec788e4e16ec9261b0a747f1482b7002d0c
|
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As per the example in #7, we were unable to
ListorGetobjects that are not watched by the controller. This change attempts to emulate what upstream controller-runtime's cache implementation does: When an informer has not been started yet, we should try to start one.The way we start a new informer is a bit hacky due to our custom
NewInformerlogic, but this should do the trick.Related issue(s)
Fixes #8
Release Notes