Support arbitrary related resources #119
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
release-note
Contributor
|
Skipping CI for Draft Pull Request. |
kcp-ci-bot
added
the
dco-signoff: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
size/XXL
Contributor
Author
|
/test all |
xrstf
force-pushed
the
more-related-resources
branch
from
8fd6894 to
80d0940
Compare
Contributor
Author
|
/test all |
2 similar comments
Contributor
Author
|
/test all |
Contributor
Author
|
/test all |
Contributor
Author
|
/retest |
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
xrstf
force-pushed
the
more-related-resources
branch
2 times, most recently
from
dec4ec9 to
0fa3f06
Compare
On-behalf-of: @SAP [email protected]
xrstf
force-pushed
the
more-related-resources
branch
from
0fa3f06 to
05155c6
Compare
Contributor
Author
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements one of the OG "yeah this will be extended in the future" tickets, allowing for related resources to be of any group, version or resource.
For this, the
PublishedResourceCRD has been extended to not takekind, but instead takegroup,versionandresource. The oldkindfield is still supported, but deprecated, and can only handle ConfigMaps and Secrets, as before. If you want to have anything else, configure GVR instead.(Why
resourceall of a sudden when everything else inside a PR is Kind-based? Because to figure out if a resource needs to be permission claimed, we would first need to figure out if that resource belongs to the same APIExport, and APIExports only contain resources and so we cannot resolve it before adding it, but to add it we need to resolve it and so Kinds are just not suitable here. I don't like it either, but ... yeah.)Integration of custom GVRs into the syncer itself was pretty harmless, the more elaborate part was the APIExport controller which now has to figure out if a related resource points to a foreign resource (of another APIExport), so it can configure the permission claims correctly. Doing that while taking into account that PublishedResources are transmitted asynchonously (in the
apiresourceschemacontroller) took a bit more code than expected.Other than that, the change is relatively straightforward.
What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #109
Release Notes