Skip to content

Commit 8383dbb

Browse files
authored
Merge pull request #221 from kbase/sdkdev
allow jackson to sync versions across dep graph
2 parents 9fa0d36 + 648b177 commit 8383dbb

1 file changed

Lines changed: 7 additions & 24 deletions

File tree

build.gradle

Lines changed: 7 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -300,29 +300,24 @@ dependencies {
300300
annotationProcessor('info.picocli:picocli-codegen:4.7.7')
301301
compileOnly('javax.servlet:servlet-api:2.5')
302302

303-
implementation('com.github.kbase:auth2_client_java:0.5.0') {
304-
exclude group: 'com.fasterxml.jackson.core' // don't upgrade yet, breaks tests
305-
}
303+
implementation('com.github.kbase:auth2_client_java:0.5.0')
306304
implementation('com.github.kbase:catalog:2.3.1') {
307305
exclude group: 'com.github.kbase', module: 'java_common'
308-
exclude group: 'com.fasterxml.jackson.core' // don't upgrade yet, breaks tests
309306
}
310307
implementation('com.github.kbase:java_common:0.3.1') {
311-
exclude group: 'com.fasterxml.jackson.core' // don't upgrade yet, breaks tests
312308
exclude group: 'net.java.dev.jna' // don't include in runtime path
313309
exclude group: 'org.eclipse.jetty.aggregate' // don't include in runtime path
314310
exclude group: 'org.syslog4j', module: 'syslog4j'
315311
}
316312
implementation('com.github.kbase:java_kidl:0.2.0')
317313
implementation('com.github.kbase:narrative_method_store:v0.3.13') {
318314
exclude group: 'com.github.kbase', module: 'java_common'
319-
exclude group: 'com.fasterxml.jackson.core' // don't upgrade yet, breaks tests
320315
// TODO DEPS fix these in NMS
321316
exclude group: 'org.mongodb'
322317
exclude group: 'org.eclipse.jetty.aggregate' // don't include in runtime path
323318
}
324-
implementation('com.fasterxml.jackson.core:jackson-annotations:2.2.3')
325-
implementation('com.fasterxml.jackson.core:jackson-databind:2.2.3')
319+
implementation('com.fasterxml.jackson.core:jackson-annotations:2.9.9')
320+
implementation('com.fasterxml.jackson.core:jackson-databind:2.9.9')
326321
implementation('com.google.guava:guava:18.0')
327322
implementation('com.googlecode.jsonschema2pojo:jsonschema2pojo-core:0.3.6')
328323
implementation('com.j2html:j2html:0.7') {
@@ -343,14 +338,10 @@ dependencies {
343338

344339
testImplementation('ch.qos.logback:logback-classic:1.1.2')
345340
testImplementation ('com.github.kbase:java_test_utilities:0.1.0') {
346-
exclude group: 'com.fasterxml.jackson.core' // don't upgrade yet, breaks tests
347341
exclude group: 'junit', module: 'junit'
348342
}
349-
testImplementation('com.github.kbase.workspace_deluxe:workspace-client:0.15.0') {
350-
exclude group: 'com.fasterxml.jackson.core' // don't upgrade yet, breaks tests
351-
exclude group: 'net.java.dev.jna' // don't include in runtime path
352-
}
353-
// needed for syslog4j. Used in java test modules and JsonServerServlet subclasses in tests
343+
testImplementation('com.github.kbase.workspace_deluxe:workspace-client:0.15.0')
344+
// needed for syslog4j. Used in JsonServerServlet subclasses in tests
354345
// but not in SDK code proper.
355346
testImplementation('net.java.dev.jna:jna:3.4.0')
356347
testImplementation("nl.jqno.equalsverifier:equalsverifier:4.0.7")
@@ -368,17 +359,9 @@ dependencies {
368359

369360
// isolate the sdk generated code dependencies from the standard dependencies
370361

371-
generatedCodeClasspath('ch.qos.logback:logback-classic:1.1.2')
372-
generatedCodeClasspath('com.fasterxml.jackson.core:jackson-databind:2.2.3')
373-
generatedCodeClasspath('com.github.kbase:auth2_client_java:0.5.0') {
374-
exclude group: 'com.fasterxml.jackson.core' // don't upgrade yet, breaks tests
375-
}
376-
generatedCodeClasspath('com.github.kbase:java_common:0.3.1') {
377-
exclude group: 'com.fasterxml.jackson.core' // don't upgrade yet, breaks tests
378-
}
362+
generatedCodeClasspath('com.github.kbase:auth2_client_java:0.5.0')
363+
generatedCodeClasspath('com.github.kbase:java_common:0.3.1')
379364
generatedCodeClasspath('javax.annotation:javax.annotation-api:1.3.2')
380-
generatedCodeClasspath('org.ini4j:ini4j:0.5.2')
381-
generatedCodeClasspath('org.syslog4j:syslog4j:0.9.46')
382365

383366
generatedTestCodeClasspath('junit:junit:4.12')
384367
}

0 commit comments

Comments
 (0)