A bit of cleanup.

Author: jeff-cohere

databases/kbase/user_federation.go

@@ -65,10 +65,9 @@ func startUserFederation() error {
 				t := time.Now()
 				topOfHour := time.Date(t.Year(), t.Month(), t.Day(), t.Hour()+1, 0, 0, 0, t.Location())
 				time.Sleep(time.Until(topOfHour))
-				kbaseUpdateChan <- struct{}{}
+				err := reloadUserTable()
 
 				// reloading errors are logged, not propagated
-				err := <-kbaseErrorChan
 				if err != nil {
 					slog.Warn(err.Error())
 				}
@@ -89,6 +88,11 @@ func usernameForOrcid(orcid string) (string, error) {
 	return username, err
 }
 
+func reloadUserTable() error {
+	kbaseUpdateChan <- struct{}{}
+	return <-kbaseErrorChan
+}
+
 // stops the user federation machinery
 func stopUserFederation() error {
 	if !kbaseUserFederationStarted {