Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dedicated modules model.py #57

Open
cmp0xff opened this issue Jun 16, 2024 · 1 comment
Open

Refactor dedicated modules model.py #57

cmp0xff opened this issue Jun 16, 2024 · 1 comment

Comments

@cmp0xff
Copy link
Collaborator

cmp0xff commented Jun 16, 2024

          If we are moving initial conditions to a dedicated module, let's also move the following lines to a dedicated module (maybe `model.py` or something).

I feel most people won't look into __init__.py unless it is related to __all__.
Maybe we only do imports in __init__.py. Something like

from hamilflow.models.harmonic_oscillator.model import SimpleHarmonicOscillator, DampdHamonicOscillator


__all__ = ["SimpleHarmonicOscillator", "DampdHamonicOscillator"]

Originally posted by @emptymalei in #54 (comment)

@cmp0xff
Copy link
Collaborator Author

cmp0xff commented Sep 3, 2024

Do we still need a dedicated module model.py for all models, @emptymalei ? At the moment, only the complicated Kepler problem has submodules. All other models are contained in one file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant