Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add z-index values to report #43

Open
98percentoats opened this issue Nov 10, 2015 · 6 comments
Open

Feature: Add z-index values to report #43

98percentoats opened this issue Nov 10, 2015 · 6 comments

Comments

@98percentoats
Copy link

I think this would be useful to see if you've ended up with ridiculous z-indexes! 👍

@vincentorback
Copy link

vincentorback commented Jun 1, 2016

Not sure how to list these tho. Show highest? Show total?
I have a little postcss-script here that lists all z-index properties, which can be a good thing to check once in a while. But maybe it’s a but much for this plugin?

@bartveneman
Copy link

Or show all unique values, like here? (personal very early side project): https://projectwallace.herokuapp.com/users/1/projects/8/metrics/unique_zindexes

@98percentoats
Copy link
Author

@vincentorback @bartveneman Personally I'd like to see the highest value and the total number of unique values. I don't think anything else is really all that useful. If you see that you've got high figure of 9999 or you have 150 (for example) different values then you know that's silly and you need to intervene.

@bartveneman
Copy link

That sounds reasonable, although I've seen some projects using groupings like 100-103 for site headers, 200-204 for some component and 900-910 for modals. As always, I guess: it depends

@vincentorback
Copy link

Yeah, it’s a good thing to see all of your z-index's to see that they stack with a reasonable amount. But I’m not sure it’s parkers job to show this. So maybe showing highest and total is good enough!

@bartveneman
Copy link

bartveneman commented Jun 9, 2016

Personally I'd like to see the highest value and the total number of unique values.

But I’m not sure it’s parkers job to show this. So maybe showing highest and total is good enough!

I think you're both right. Parker usually shows averages/means, so deviating from that would be indeed a little strange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants