Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

np.float is deprecated #47

Open
Javihaus opened this issue Apr 1, 2024 · 1 comment
Open

np.float is deprecated #47

Javihaus opened this issue Apr 1, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@Javihaus
Copy link

Javihaus commented Apr 1, 2024

np.float you are using in impute function is deprecated (line 404 in great.py file). You have to change to float or to np.float64:
Current:
df_curr[self.num_cols] = df_curr[self.num_cols].astype(np.float)
Change:
df_curr[self.num_cols] = df_curr[self.num_cols].astype(float)
or
df_curr[self.num_cols] = df_curr[self.num_cols].astype(np.float64)

@unnir unnir added the good first issue Good for newcomers label Apr 19, 2024
@unnir
Copy link
Collaborator

unnir commented Apr 19, 2024

Thank you, we will adjust the code. Also, a PR is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants