Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.8 Tree-sitter highlight groups don't respect hl links #22

Open
katawful opened this issue Aug 26, 2022 · 2 comments
Open

0.8 Tree-sitter highlight groups don't respect hl links #22

katawful opened this issue Aug 26, 2022 · 2 comments
Assignees
@katawful
Labels
enhancement New feature or request Neovim update For implementing new Neovim features refactor Mass changes to the code for various reasons

Comments

@katawful
Copy link
Owner

Due to the breaking change found in 0.8, TS support will have to be reworked to maintain compatibility with 0.7 and 0.8 when it releases

Creating this issue now so I am aware of this when moving forward with #18
@katawful katawful self-assigned this Aug 26, 2022
@katawful katawful added Neovim update For implementing new Neovim features enhancement New feature or request refactor Mass changes to the code for various reasons labels Aug 26, 2022
@katawful katawful pinned this issue Sep 5, 2022
@katawful
Copy link
Owner Author

katawful commented Sep 7, 2022

I'm not seeing any breakages

@katawful
Copy link
Owner Author

katawful commented Sep 7, 2022

I attempted to use just the @group style hl names for 0.8 users, however for some reason none of them would use the highlight links I wanted. Such as @variable linked to Variable. It would always default to the old names, TSVariable

Keeping this open, but renaming and removing from milestone as it doesn't impede functionality

@katawful katawful removed this from the Release: v1.0 "Rotund Donskoy" milestone Sep 7, 2022
@katawful katawful changed the title 0.8 treesitter breaking change 0.8 Tree-sitter highlight groups don't respect hl links Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katawful katawful

Labels
enhancement New feature or request Neovim update For implementing new Neovim features refactor Mass changes to the code for various reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@katawful