Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

ci: test: k8s: agent_image rootfs check #5790

Closed
stevenhorsman opened this issue Nov 6, 2023 · 1 comment · Fixed by #5791
Closed

ci: test: k8s: agent_image rootfs check #5790

stevenhorsman opened this issue Nov 6, 2023 · 1 comment · Fixed by #5791
Assignees

Comments

@stevenhorsman
Copy link
Member

In the kubernetes agent_image test we currently have a check:

echo "Check the image was not pulled in the host"
	local pod_id=$(kubectl get pods -o jsonpath='{.items..metadata.name}')
	retrieve_sandbox_id
	rootfs=($(find /run/kata-containers/shared/sandboxes/${sandbox_id}/shared \
		-name rootfs))
	[ ${#rootfs[@]} -eq 1 ]

to ensure that the image hasn't been pulled onto the host. The reason that the check is for a single rootfs is that we found that the pause image was always pulled on the host, presumably due to it being needed to create the pod sandbox.

With the introduction of the nydus-snapshotter code we've found that on some systems (SE and TDX) it appears to be in a different location with nydus-snapshotter, so check for 1, or 0. See an issue at #5781 to track this.

We don't have time to understand this fully now, so we just want the tests to pass and check that we don't have both the pause and main pod container image pulled

@stevenhorsman stevenhorsman self-assigned this Nov 6, 2023
stevenhorsman added a commit to stevenhorsman/tests that referenced this issue Nov 6, 2023
In the kubernetes agent_image test we currently have a check:
```
echo "Check the image was not pulled in the host"
	local pod_id=$(kubectl get pods -o jsonpath='{.items..metadata.name}')
	retrieve_sandbox_id
	rootfs=($(find /run/kata-containers/shared/sandboxes/${sandbox_id}/shared \
		-name rootfs))
	[ ${#rootfs[@]} -eq 1 ]
```
to ensure that the image hasn't been pulled onto the host.
The reason that the check is for a single rootfs is that we found that
the pause image was always pulled on the host, presumably due to
it being needed to create the pod sandbox.

With the introduction of the nydus-snapshotter code we've found
that on some systems (SE and TDX) it appears to be in a different
location with nydus-snapshotter, so check for 1, or 0. See an issue
at kata-containers#5781 to track this.

We don't have time to understand this fully now, so we just want the
tests to pass and check that we don't have both the pause and test
pod container image pulled, so set the check to pass if there are
1, or 0 rootfs' found in /run/kata-containers/shared/sandboxes/

Fixes: kata-containers#5790
Signed-off-by: stevenhorsman <[email protected]>
@stevenhorsman stevenhorsman linked a pull request Nov 6, 2023 that will close this issue
@stevenhorsman
Copy link
Member Author

Closed with #5791 merging

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant