-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge options should extend arrays or be customizable #246
Comments
@johnjbarton It's not entirely clear to me which two pieces of configuration are being merged by the code in question. I assume this isn't about task options vs task data, but something else rather. Is that right? |
Looks like this is grunt task data (specified in gruntfile) merging with command line 'options'. If the PR had tests this would be clearer (and I would ask for one). |
Please have a look at https://github.com/LoveIsGrief/grunt-karma-poc-246 for an example of the behavior I was talking about. It's a contrived example since I cannot remember the exact scenario. It's been too long. As for writing tests, I think it's out of scope for this bug. Tests don't exist for this repo and it would be a different task to add them just to test my PR. I hope the repo I created is enough. |
When overriding options e.g the plugins and frameworks, the default behavior of
_.merge
returns (for me) surprising results (see below). Therfore I believe it should either be possible toa. customize merges using a new option e.g
mergeCustomizer
b. extend array by default e.g
_.merge behavior
The text was updated successfully, but these errors were encountered: