Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build cava because of broken configure.ac #605

Closed
Alxhr0 opened this issue Nov 24, 2024 · 2 comments
Closed

Can't build cava because of broken configure.ac #605

Alxhr0 opened this issue Nov 24, 2024 · 2 comments

Comments

@Alxhr0
Copy link

Alxhr0 commented Nov 24, 2024

READ THIS BEFORE CREATING NEW ISSUE

Are you using cava from a package repository, like AUR?

No, manually built the latest git commit

ALWAYS TRY TO BUILD AND RUN FROM THE SOURCE CODE ON GITLAB BEFORE POSTING ISSUES

If the issue is resolved when building from source, do not post issues here.

Describe the bug

A clear and concise description of what the bug is.

Can't build cava git because of a configure.ac error

libtoolize: Consider adding 'AC_CONFIG_MACRO_DIRS([m4])' to configure.ac,
libtoolize: and rerunning libtoolize and aclocal.
configure.ac:306: error: _AX_CHECK_GL_MANUAL_LIBS_GENERIC: argument must not be empty
lib/m4sugar/m4sh.m4:690: _AS_IF_ELSE is expanded from...
lib/m4sugar/m4sh.m4:697: AS_IF is expanded from...
/usr/share/aclocal/ax_check_gl.m4:187: _AX_CHECK_GL_MANUAL_LIBS_GENERIC is expanded from...
lib/m4sugar/m4sh.m4:595: AS_CASE is expanded from...
/usr/share/aclocal/ax_check_gl.m4:253: AX_CHECK_GL is expanded from...
lib/m4sugar/m4sh.m4:697: AS_IF is expanded from...
lib/m4sugar/m4sh.m4:697: AS_IF is expanded from...
configure.ac:306: the top level`

To Reproduce

Steps to reproduce the behavior:

  1. Git clone the latest git commit
  2. Try to build it without any flags

Workaround

AS_IF([test "x$enable_output_sdl" != "no"], [
AC_CHECK_LIB(SDL2,SDL_Init, have_sdl=yes, have_sdl=no)
    if [[ $have_sdl = "yes" ]] ; then
      LIBS="$LIBS -lSDL2"
      CPPFLAGS="$CPPFLAGS -DSDL"

      dnl ######################
      dnl checking for opengl (only if we know we have sdl)
      dnl ######################
      AC_ARG_ENABLE([output_sdl_glsl],
        AS_HELP_STRING([--disable-output-sdl-glsl],
          [do not include support for output with sdl_glsl])
      )
      AS_IF([test "x$enable_output_sdl_glsl" != "no"], [
             m4_ifdef([AX_CHECK_GL], [
                       AX_CHECK_GL(have_opengl=yes, have_opengl=no)
                       ], [
                           AC_MSG_NOTICE([You need to install the autoconf archives to check for opengl. Remember to re-run autogen.sh.])
                           have_opengl=no
                           ])
      if [[ $have_opengl = "yes" ]] ; then
        LIBS="$LIBS $GL_LIBS"
        CPPFLAGS="$CPPFLAGS -DSDL_GLSL $GL_CFLAGS"
      fi

      if [[ $have_opengl = "no" ]] ; then
        AC_MSG_NOTICE([INFO: building without sdl_glsl (opengl) support])
      fi
      ],
        [have_opengl=no]
      )
    fi

    if [[ $have_sdl = "no" ]] ; then
      AC_MSG_NOTICE([INFO: building without sdl support])
    fi
],
  [have_sdl=no]
)

Removing this from configure.ac allows the autogen.sh script to run and Cava builds fine then

Expected behavior

Cava should build fine

Desktop (please complete the following information):

  • OS: NixOS
  • Version: 25.05 Unstable

Terminal emulator

  • Konsole
  • 24.05
@Alxhr0 Alxhr0 changed the title Can;t build cava because of broken configure.ac Can't build cava because of broken configure.ac Nov 24, 2024
@huynhhoanglong
Copy link

I got same issues

@karlstav
Copy link
Owner

duplicate #594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants