Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox sidebar causes extreme logging on some pages, leading to a noticeable performance issue #335

Open
MTRNord opened this issue Oct 6, 2022 · 4 comments
Labels
frontend Related to browser extension performance

Comments

@MTRNord
Copy link

MTRNord commented Oct 6, 2022

Hi I am using promnesia for firefox and in the chat app develop.element.io specifically I am getting lots and lots of logs which seems to not only cause UI blocking for the tab but also quite a high memory usage. I confirmed that turning off promnseia fixes the performance issues, which is why I think this may be a bug here.

image

There is an endless stream of these logs happening. It seems to specifically only be an issue with this page for reasons I dont get currently.

I am happy to provide any more info needed to debug this :)

@MTRNord
Copy link
Author

MTRNord commented Oct 6, 2022

@seanbreckenridge
Copy link
Contributor

seanbreckenridge commented Oct 10, 2022

I think this is related to #177 and #307

If you want to ignore the site for now, you can right click the promnesia icon and click 'exclude globally'

For example if the page was

https://example.somesite.com/page

You could ignore that in particular, or use a regex (start end with /, like): /example.somsite.com/*/

These can be edited in the extension preferences as well

image

@MTRNord
Copy link
Author

MTRNord commented Oct 10, 2022

Thanks I will give that a try :) It indeed sounds related.

@karlicoss karlicoss added ui Related to browser UI performance frontend Related to browser extension and removed ui Related to browser UI labels Dec 30, 2022
@karlicoss
Copy link
Owner

I think it's not necessarily caused by #177 or #307 -- even with single update from the background page it takes it a while to process highlights. I wonder if the algorithm needs a bit of a speedup (although still crazy that it takes it more than a second for a single pass)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Related to browser extension performance
Projects
None yet
Development

No branches or pull requests

3 participants