Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion – unicorn colourful icon options #56

Open
OrionRandD opened this issue Oct 21, 2023 · 4 comments
Open

Suggestion – unicorn colourful icon options #56

OrionRandD opened this issue Oct 21, 2023 · 4 comments

Comments

@OrionRandD
Copy link

I have used this extension for years...
But, it is difficult to see the unicorn (black and white) in my icon bar...
Could you add more unicorn colourful icons options for us to select and make a better contrast depending on the firefox/chromium icon bar background?

Thx a lot
@rosstimson
Copy link

I have this too. When browser is set to match the OS in terms of light or dark mode dependent on the time of day the Grasp icon disappears when in dark mode. Even a quick hack of giving it a white background would be better than virtually invisible.

@OrionRandD
Copy link
Author

I have this too. When browser is set to match the OS in terms of light or dark mode dependent on the time of day the Grasp icon disappears when in dark mode. Even a quick hack of giving it a white background would be better than virtually invisible.

Yes. In my case, I cannot use any firefox/chromium dark theme, because the icon just become invisible. But, it seems that our request have been ignored... :(

rosstimson added a commit to rosstimson/grasp that referenced this issue Mar 22, 2024
@rosstimson
fix: karlicoss#56 add background colour to icon
d50e21a 
With a transparent background the icon becomes invisible when the
browser is using a dark colour theme. This change gives it a
background colour for visibility.

FYI the shade of green is from the shades of green used in https://orgmode.org/
@rosstimson
Copy link

@OrionRandD I've created a PR for this that is rudimentary but it at least works and makes things better. You might want to take a look. The screenshots in my PR are from Arc which is my primary browser but I assume it'll be similar in all browsers.

@OrionRandD
Copy link
Author

@OrionRandD I've created a PR for this that is rudimentary but it at least works and makes things better. You might want to take a look. The screenshots in my PR are from Arc which is my primary browser but I assume it'll be similar in all browsers.

Great! Thx a ton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rosstimson @OrionRandD