Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideas and tasks #12

Open
kardwen opened this issue Jan 16, 2025 · 3 comments
Open

Ideas and tasks #12

kardwen opened this issue Jan 16, 2025 · 3 comments

Comments

@kardwen
Copy link
Owner

kardwen commented Jan 16, 2025

Quick list of ideas and open tasks:

  • Tests
  • Mouse support overhaul
  • Localization for last modified column
  • Button animations for keyboard shortcuts
  • Background updates
  • Support for symbolic links in store
  • Tree view for folders (for example Ratatui Tree Widget)
  • Configuration file for setting options
  • Theming, e.g. for using the terminal color theme
  • Decryption and caching of password files, this would allow for
    • showing which fields are set in the password preview
    • displaying flags for set fields in the password table
  • Sorting of the password table by columns
  • TTY improvements:
    • Alternative widget mode without Unicode characters
    • TTY color theme with 16 colors
@grouzen
Copy link
Contributor

grouzen commented Jan 16, 2025

From my side, I'd like to add the following feature request: set the window title explicitly so that https://github.com/cdown/clipmenu can recognize the copy events and ignore them. It is required to avoid revealing copied passwords in the clipmenu's dialog.

Background:
clipmenud has a configuration to filter out copy events by X11 window name:

- $CM_IGNORE_WINDOW: disable recording the clipboard in windows where the windowname matches the given regex (e.g. a password manager), do not ignore any windows if unset or empty (default: unset)

Currently, I don't have an option to filter such events because the X11 window name remains the same, in my case, it is "urxvt". It would be nice to set it to something like "passepartui"

@kardwen
Copy link
Owner Author

kardwen commented Jan 16, 2025

The terminal window title is set with my current x11 setup with kitty but I can reproduce the missing title on xfce4-terminal. This can be an upstream issue in ratatui or crossterm or it has to be set explicitly: https://docs.rs/crossterm/0.28.1/crossterm/terminal/struct.SetTitle.html

I think the ratatui::init function that I use should already handle it: https://docs.rs/ratatui/latest/ratatui/fn.init.html

@grouzen
Copy link
Contributor

grouzen commented Jan 24, 2025

I did a quick research on this. Yes, we can easily set a title by executing a SetTitle crossterm command during app initialization in main.rs:

execute!(stdout(), SetTitle("passepartui"))?;

However, it seems there is currently no way to restore the old title on exit since crossterm doesn't support GetTitle query. There are a couple of old issues on GitHub:

UPDATE:
Given the above information, I'm considering adding a PR to set a title but hide this under the command line option, similar to how you did with --tty-pinentry. It will allow users like me to use the updated window title in some scenarios despite having an issue restoring the original window name.
PR: #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants