Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An option for opening links in new tabs #31

Open
qykong opened this issue Mar 4, 2020 · 3 comments
Open

An option for opening links in new tabs #31

qykong opened this issue Mar 4, 2020 · 3 comments

Comments

@qykong
Copy link
Contributor

qykong commented Mar 4, 2020

Hi, thanks for this add-on. I really enjoy it so far!

While browsering through devo, I noticed one missing piece for myself is the feature to open links in new tabs. This would allow one to keep the scrolling status of the add-on page after a peek to a link in new tab. Hopefully this sounds to be useful.

This should be easy to implement with just a target="_blank" attribute. The tricky part is where to put the switch for turning it on (maybe a small popup menu for placing all different configurations including the existing switch for night mode).

Let me know if this is something you are interested in and if possible I'm happy to contribute a PR :D

@qykong qykong changed the title An option for allowing to open links in new tabs An option for opening links in new tabs Mar 4, 2020
@karakanb
Copy link
Owner

karakanb commented Mar 4, 2020

Hi there, thanks for the feedback!

Devo allows having a quick overview of these platforms, so it is not really meant to be used as a page that users will browse, that's why I made the links to be opened up on the page instead of a new one. I think it is a nice feature to have, but I wouldn't like it to be the default behavior, so I'd accept it only if it is behind a feature toggle in a settings page. I mentioned this in #28, maybe Viktor is working on that, I don't know. If so, I think it'd be better if we wait for it to be implemented, or maybe you guys can collaborate on that. What do you think?

@qykong
Copy link
Contributor Author

qykong commented Mar 4, 2020

Hi, thanks for your reply.

This makes sense and I agree it should be just a feature toggle rather than the default. Let's wait for Viktor's PR then.

@kyng-cytro
Copy link

Hi, thanks for your reply.

This makes sense and I agree it should be just a feature toggle rather than the default. Let's wait for Viktor's PR then.

ctrl + click ? at least in chrome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants