-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
:jsload-callback
should call core/mount-root instead of start-descjop!
#36
Comments
Thank you! I will check the bug, and try to fix if it has probrem. |
@karad Upon further inspection, this line here will also be problematic and I think it should likely be removed. That line will effectively call the An example of how to make such a function call from an index.html file can be seen here, which references this function here |
Hey, I think there is a subtle bug in the profile dev init files.
The
:jsload-callback
(effectively) callscore/init!
; however, it should instead callcore/mount-root
. This is an important distinction, because thecore/init!
function should run things once when the application first loads, andcore/mount-root
should be called every time figwheel reloads.Bug is here:
https://github.com/karad/lein_template_descjop/blob/master/resources/leiningen/new/descjop/reagent__src__front__profile__dev__init.cljs#L10
:jsload-callback should instead call
mount-root
:https://github.com/karad/lein_template_descjop/blob/master/resources/leiningen/new/descjop/reagent__src__front__core.cljs#L10
The text was updated successfully, but these errors were encountered: