Paper 1.8.8-1.12.2: Hover text acting weird

[MotikaCraft-TheJoshua]

Are you using MySQL?

Yes

Are you using a proxy?

Yes - Velocity

"/version ChatControlRed" - plugin version

11.3.6

Optional: Error log

/

ZIP of "/chc debug"

I have clean install, only connected mysql to database, and added this formatting part:

  edition-java:
    Sender_Condition: '!{sender_is_discord}'
    Message: '&8[&a&lJE&r&8] &r'
    Hover:
      - '<gray><italic>Ovaj igrac trenutno pristupa serveru putem</italic></gray> <green><bold>Java Edition</bold></green> <gray><italic>klijenta</italic></gray>'

Steps to reproduce

1. Install ChatControl 11.3.6
2. Apply next formattings (first test one, then test another):

  edition-java:
    Sender_Condition: '!{sender_is_discord}'
    Message: '&8[&a&lJE&r&8] &r'
    Hover:
      - 'Ovaj igrac trenutno pristupa serveru putem Java Edition klijenta'

with this, this should be output:

and

  edition-java:
    Sender_Condition: '!{sender_is_discord}'
    Message: '&8[&a&lJE&r&8] &r'
    Hover:
      - '<gray><italic>Ovaj igrac trenutno pristupa serveru putem</italic></gray> <green><bold>Java Edition</bold></green> <gray><italic>klijenta</italic></gray>'

with this, this should be output:

---

You can see the difference, this was not happening previously

[MotikaCraft-TheJoshua]

I apologize for the oversight, this is happening on Paper 1.8.8 - 1.12.2, i have just tested, i thought it was my Paper 1.21.4 test server

[devpedrobarbosa]

Hi @MotikaCraft-TheJoshua.

What happens is: Legacy Minecraft has a limit of 55 characters per hover line. So, if your line is > 55 chars long, ChatControl will break it down as needed with line breakers (\n). Those new lines will have no color attached to them, probably causing weird bugs like the ones you showed and I was able to reproduce here.

So, what I would recommend is to break the lines by yourself, keeping in mind that 55 chars limit.
Obs: the limit is considered without mini tags (<>)

Currently, the default plain gray styling is only applied to the first line of the part. That means if you have this setup:

It will come up like this:

For now, do this instead:

This specific part will be patched asap, though.

Thanks for sharing that.

[MotikaCraft-TheJoshua]

Hi @MotikaCraft-TheJoshua.

What happens is: Legacy Minecraft has a limit of 55 characters per hover line. So, if your line is > 55 chars long, ChatControl will break it down as needed with line breakers (\n). Those new lines will have no color attached to them, probably causing weird bugs like the ones you showed and I was able to reproduce here.

So, what I would recommend is to break the lines by yourself, keeping in mind that 55 chars limit. Obs: the limit is considered without mini tags (<>)

Currently, the default plain gray styling is only applied to the first line of the part. That means if you have this setup:

It will come up like this:

For now, do this instead:

This specific part will be patched asap, though.

Thanks for sharing that.

Hello, thanks for fast response
i think you did not fully cover my concerns

i hope you see the difference

This is on the SAME server (1.8-1.12), with different formats, same text, i just formatted it differently - i hope you now understand better what i am talking about - same text different coloring

I am talking more about this

  edition-java:
    Sender_Condition: '!{sender_is_discord}'
    Message: '&8[&a&lJE&r&8] &r'
    Hover:
      - '<gray><italic>Ovaj igrac trenutno pristupa serveru putem</italic></gray> <green><bold>Java Edition</bold></green> <gray><italic>klijenta</italic></gray>'

because this colored and formatted, it is no different text than the first one i showed above and you sent, is it counting all the formatting now? you said 55 chars limit, is it counting even "<" and ">" and "gray" and "italic" etc, for this?

[devpedrobarbosa]

@MotikaCraft-TheJoshua
Take a look at what is going on:

So the line which length is used to decide wether wrapping or not is the stripped one. Though, when it comes to actually breaking the line down, it obviously has to break down the original line with the tags, otherwise styling would be lost.

I am not sure that the logic of breaking down the line is 100%, will verify that.

I tried doing this:

  edition-java:
    Sender_Condition: '!{sender_is_discord}'
    Message: '&8[&a&lJE&r&8] &r'
    Hover:
      - '&7&oOvaj igrac trenutno pristupa serveru putem &a&lJava Edition &7&oklijenta'

And this happened:

That is one solution for now: using either legacy color codes or short mini tags.
Also, do the wrapping yourself it auto wrapping is messing it up.

I don't know if theres is a reason for that feature to exist and specially for it not to be configurable.
I will investigate it further and report any changes on that to you.

[kangarko]

@devpedrobarbosa can you check our code > we have this split mechanism t here... and see what happens if you remove the mechanism, or perhaps you can improve it to not take into account mini tags, just test these scenarious and see if we can improve on our end