regex for the `cycle` tag gives wrong results #179

live627 · 2023-02-11T07:31:29Z

Code to reproduce

{% cycle 44, "one", "three" %}
{% cycle "one", "two", "three" %}
{% cycle "one", "two ::,,ree" %}
{% cycle "one", "two ::,,ree" %}
{% cycle "namedd": "one", "two ::,,ree" %}

Expected output

44
one
one
two ::,,ree
one

Actual output

44
one
one

What happened?

$namedSyntax regex is too greedy, thinking that the strings before the colons are names.

/((?:(?:"[^"]*"|'[^']*')|(?:[^\s,\|'"]|(?:"[^"]*"|'[^']*'))+))\s*\:\s*(.*)/

Its output:

array (size=3)
  0 => string 'one", "two ::,,ree" ' (length=20)
  1 => string 'one", "two' (length=10)
  2 => string ':,,ree" ' (length=8)
array (size=3)
  0 => string 'one", "two ::,,ree" ' (length=20)
  1 => string 'one", "two' (length=10)
  2 => string ':,,ree" ' (length=8)

array (size=3)
  0 => string '"namedd": "one", "two ::,,ree" ' (length=31)
  1 => string '"namedd"' (length=8)
  2 => string '"one", "two ::,,ree" ' (length=21)

I'm crafting new ones to fix this.

The text was updated successfully, but these errors were encountered:

sanmai mentioned this issue Feb 11, 2023

Make the regex for the cycle tag less greedy #180

Closed

live627 linked a pull request May 10, 2024 that will close this issue

Make the regex for the cycle tag less greed #217

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

regex for the `cycle` tag gives wrong results #179

regex for the `cycle` tag gives wrong results #179

live627 commented Feb 11, 2023

regex for the cycle tag gives wrong results #179

regex for the cycle tag gives wrong results #179

Comments

live627 commented Feb 11, 2023

Code to reproduce

Expected output

Actual output

What happened?

regex for the `cycle` tag gives wrong results #179

regex for the `cycle` tag gives wrong results #179