Fix split filter for php >=8.0 in case of empty separator (#213)

Co-authored-by: pavlikovsky <[email protected]>
kalimatas · Mar 19, 2024 · de705d5 · de705d5
1 parent 1f4477c
commit de705d5
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/Liquid/StandardFilters.php b/src/Liquid/StandardFilters.php
@@ -621,6 +621,10 @@ public static function split($input, $pattern)
 			return [];
 		}
 
+		if ($pattern === '') {
+			return mb_str_split($input);
+		}
+
 		return explode($pattern, $input);
 	}
 

diff --git a/tests/Liquid/StandardFiltersTest.php b/tests/Liquid/StandardFiltersTest.php
@@ -881,6 +881,21 @@ public function testSplit()
 				array('123', '123', '123'),
 				'0'
 			),
+			array(
+				'phrase',
+				array('p', 'h', 'r', 'a', 's', 'e'),
+				''
+			),
+			array(
+				'phrase',
+				array('phrase'),
+				null
+			),
+			array(
+				'123 123 123',
+				array('123', '123', '123'),
+				' '
+			),
 		);
 
 		foreach ($data as $item) {