Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grails 3.x version #33

Open
edwardotis opened this issue Nov 17, 2016 · 18 comments
Open

Grails 3.x version #33

edwardotis opened this issue Nov 17, 2016 · 18 comments

Comments

@edwardotis
Copy link

The plugin has been very useful with grails 2.
Is there a grails 3 version on the roadmap?

@snimavat
Copy link

snimavat commented Feb 7, 2017

IS there plan to upgrade the plugin to grails 3 officially ? -- or i can branch it, put efforts to upgrade and release a grails 3 version myself ?

@Alotor
Copy link
Member

Alotor commented Feb 7, 2017

Hi, we're currently not putting more efforts into the plugin but I would love to help if someone is committed to migrate it to version 3.x

I think there are several challenges because a lot has changed.

@snimavat
Copy link

snimavat commented Feb 7, 2017

I would be happy to migrate the plugin to grails 3... i will keep u updated of progress.

@snimavat
Copy link

snimavat commented Feb 10, 2017

@Alotor i got the basic functionality working with grails 3 -- here's my branch - you should be able to do grails run-app and test it with grails 3.2.4 -- https://github.com/snimavat/grails-admin-interface/tree/grails3

I will be working on it to get it working properly with grails 3, and i have plan to refactor few things, make it lil more customizable and add few new features

Right now i am testing it with hibernate, but will remove the hibernate dep once i am done

@snimavat
Copy link

@Alotor there's one javascript file missing grails-admin/js/widgets/relationpopup.js and browser complains about that, does this file even expected to exist ? i think it needs to be removed from widget js ?

@Alotor
Copy link
Member

Alotor commented Feb 19, 2017

Thanks a lot! I'll try to check this today. The script missing was replaced when we separated the relationship in several widgets. The first version there was only "one to many" relationships (if memory serves) and then we created one for each type.

@Alotor
Copy link
Member

Alotor commented Feb 19, 2017

@snimavat can you open a Pull Request so I can comment and push my own changes?

Looks very prominsing but I've found some issues with the static resources. Moving them to src/main/resources/public instead of src/main/webapp seems to do the trick but then is necessary to change more things in the resolution.

@snimavat
Copy link

snimavat commented Feb 21, 2017

@Alotor do you have plan to maintain and ehance the plugin ? Otherwise i can publish the new version from my repo and i have plan to support and maintain it for a long time.

@edwardotis
Copy link
Author

edwardotis commented Apr 25, 2017

@snimavat @Alotor Hi guys, I would like to try Sudhir's grails3 plugin. What is the best way to do that?

And have Alonso's concerns been addressed with the static resources?

@snimavat
Copy link

@edwardotis i have one package published here, the source is in my fork.

No, i have not made changed to static resources...

Note: even though the plugin would work with grails 3 (i tried it, works almost, but could be some bugs).. i dont plan to maintain it forever.... but if u want to start working on it, start with my fork and u should have a working grails 3 version

@edwardotis
Copy link
Author

Thanks, I'll see how it works with my domains and use cases

@edwardotis
Copy link
Author

@snimavat The dependency is not resolving with my usual repos .
What do I need to add for it to pickup https://bintray.com/snimavat/grails-plugins/grails-admin-interface ?

repositories {
    mavenLocal()
    maven { url "https://repo.grails.org/grails/core" }
    mavenCentral()
    jcenter()
}

And:
compile 'grails.plugin.admin-interface:grails-admin-interface:3.0.1.RC1'
Error

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'grails_server3'.
> Could not resolve all dependencies for configuration ':runtime'.
   > Could not find grails.plugin.admin-interface:grails-admin-interface:3.0.1.RC1.
     Searched in the following locations:
...
         file:/home/me/.m2/repository/grails/plugin/admin-interface/grails-admin-interface/3.0.1.RC1/grails-admin-interface-3.0.1.RC1.pom
         file:/home/me/.m2/repository/grails/plugin/admin-interface/grails-admin-interface/3.0.1.RC1/grails-admin-interface-3.0.1.RC1.jar
         https://repo.grails.org/grails/core/grails/plugin/admin-interface/grails-admin-interface/3.0.1.RC1/grails-admin-interface-3.0.1.RC1.pom
         https://repo.grails.org/grails/core/grails/plugin/admin-interface/grails-admin-interface/3.0.1.RC1/grails-admin-interface-3.0.1.RC1.jar
         https://repo1.maven.org/maven2/grails/plugin/admin-interface/grails-admin-interface/3.0.1.RC1/grails-admin-interface-3.0.1.RC1.pom
         https://repo1.maven.org/maven2/grails/plugin/admin-interface/grails-admin-interface/3.0.1.RC1/grails-admin-interface-3.0.1.RC1.jar
         https://jcenter.bintray.com/grails/plugin/admin-interface/grails-admin-interface/3.0.1.RC1/grails-admin-interface-3.0.1.RC1.pom
         https://jcenter.bintray.com/grails/plugin/admin-interface/grails-admin-interface/3.0.1.RC1/grails-admin-interface-3.0.1.RC1.jar

@edwardotis
Copy link
Author

@snimavat And regardless, could you submit a pull request to the kaleidos project so that @Alotor can comment and merge his 3.x fixes?

@snimavat
Copy link

You need to add maven repo

 maven { url "https://dl.bintray.com/snimavat/grails-plugins " }

compile 'grails.plugin.admin-interface:grails-admin-interface:3.0.1.RC1'

@snimavat
Copy link

PR done

@edwardotis
Copy link
Author

Thanks, that fixed the dependency issue for me. That additional repo requirement might be good to add to the README

@edwardotis
Copy link
Author

edwardotis commented Apr 25, 2017

@snimavat Hi, I'm getting 500 errors when I navigate to the /admin, /admin/list/some-domain, and /admin/add/some-domain. Can you enable Issues on your fork so I can post the stacktraces?

@snimavat
Copy link

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants