Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MipNerf360 does not follow article and formal implementation of Prop Module #38

Open
doronpor opened this issue Apr 30, 2023 · 0 comments

Comments

@doronpor
Copy link

MipNerf360 implementation diverges from the formal implementation and creates two different Prop modules.
https://github.com/kakaobrain/nerf-factory/blob/main/src/model/mipnerf360/model.py#L229

In the article and formal implementation, a single Prop module is created and used (twice).
https://github.com/google-research/multinerf/blob/main/internal/models.py#L99
https://github.com/google-research/multinerf/blob/main/internal/models.py#L221

as indicated by the article, in the beginning of 5. Optimization section:
"We do two stages of evaluation and resampling of the proposal MLP"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant