Skip to content

Commit 0a25f49

Browse files
committed
Remove unnecessary Option in filename for importAbsolute and importRelative
In all cases this methods called with Some(...)
1 parent 98de60b commit 0a25f49

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

js/src/main/scala/io/kaitai/struct/format/JavaScriptClassSpecs.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ class JavaScriptClassSpecs(importer: JavaScriptImporter, firstSpec: ClassSpec)
1313
val MODE_REL = "rel"
1414
val MODE_ABS = "abs"
1515

16-
override def importRelative(name: String, path: List[String], inFile: Option[String]): Future[Option[ClassSpec]] =
16+
override def importRelative(name: String, path: List[String], inFile: String): Future[Option[ClassSpec]] =
1717
doImport(name, path, MODE_REL)
18-
override def importAbsolute(name: String, path: List[String], inFile: Option[String]): Future[Option[ClassSpec]] =
18+
override def importAbsolute(name: String, path: List[String], inFile: String): Future[Option[ClassSpec]] =
1919
doImport(name, path, MODE_ABS)
2020

2121
def doImport(name: String, path: List[String], mode: String): Future[Option[ClassSpec]] = {

jvm/src/main/scala/io/kaitai/struct/formats/JavaClassSpecs.scala

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,14 @@ class JavaClassSpecs(relPath: String, absPaths: Seq[String], firstSpec: ClassSpe
2727
private val relFiles: concurrent.Map[String, ClassSpec] = new ConcurrentHashMap[String, ClassSpec]().asScala
2828
private val absFiles: concurrent.Map[String, ClassSpec] = new ConcurrentHashMap[String, ClassSpec]().asScala
2929

30-
override def importRelative(name: String, path: List[String], inFile: Option[String]): Future[Option[ClassSpec]] = Future {
30+
override def importRelative(name: String, path: List[String], inFile: String): Future[Option[ClassSpec]] = Future {
3131
Log.importOps.info(() => s".. importing relative $name")
3232
JavaClassSpecs.cached(path, inFile, relFiles, name, (_) =>
3333
JavaKSYParser.fileNameToSpec(s"$relPath/$name.ksy")
3434
)
3535
}
3636

37-
override def importAbsolute(name: String, path: List[String], inFile: Option[String]): Future[Option[ClassSpec]] = Future {
37+
override def importAbsolute(name: String, path: List[String], inFile: String): Future[Option[ClassSpec]] = Future {
3838
Log.importOps.info(() => s".. importing absolute $name")
3939
JavaClassSpecs.cached(path, inFile, absFiles, name, tryAbsolutePaths)
4040
}
@@ -62,7 +62,7 @@ class JavaClassSpecs(relPath: String, absPaths: Seq[String], firstSpec: ClassSpe
6262
object JavaClassSpecs {
6363
def cached(
6464
path: List[String],
65-
inFile: Option[String],
65+
inFile: String,
6666
cacheMap: mutable.Map[String, ClassSpec],
6767
name: String,
6868
importOp: (String) => ClassSpec
@@ -80,7 +80,7 @@ object JavaClassSpecs {
8080
cacheMap(name) = spec
8181
Some(spec)
8282
} catch {
83-
case err: Throwable => throw ErrorInInput(err, path, inFile).toException
83+
case err: Throwable => throw ErrorInInput(err, path, Some(inFile)).toException
8484
}
8585
}
8686
}

shared/src/main/scala/io/kaitai/struct/format/ClassSpecs.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,6 @@ abstract class ClassSpecs(val firstSpec: ClassSpec) extends mutable.HashMap[Stri
5959
}
6060
}
6161

62-
def importRelative(name: String, path: List[String], inFile: Option[String]): Future[Option[ClassSpec]]
63-
def importAbsolute(name: String, path: List[String], inFile: Option[String]): Future[Option[ClassSpec]]
62+
def importRelative(name: String, path: List[String], inFile: String): Future[Option[ClassSpec]]
63+
def importAbsolute(name: String, path: List[String], inFile: String): Future[Option[ClassSpec]]
6464
}

shared/src/main/scala/io/kaitai/struct/precompile/LoadImports.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class LoadImports(specs: ClassSpecs) {
4747
private def loadImport(name: String, path: List[String], curClass: ClassSpec, workDir: ImportPath): Future[List[ClassSpec]] = {
4848
Log.importOps.info(() => s".. LoadImports: loadImport($name, workDir = $workDir)")
4949

50-
val inFile = Some(curClass.fileNameAsStr)
50+
val inFile = curClass.fileNameAsStr
5151
val impPath = ImportPath.fromString(name)
5252
val fullPath = ImportPath.add(workDir, impPath)
5353

0 commit comments

Comments
 (0)