Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log view skips commits with authors containing brackets #197

Open
glasser opened this issue Feb 8, 2022 · 1 comment · May be fixed by #298
Open

Log view skips commits with authors containing brackets #197

glasser opened this issue Feb 8, 2022 · 1 comment · May be fixed by #298
Labels
bug Something isn't working

Comments

@glasser
Copy link

glasser commented Feb 8, 2022

The popular Renovate bot creates commits whose author name is renovate[bot].

The edamagit log parser uses a log line parser that explicitly breaks if author names have brackets in them. So these lines get completely skipped in the log list, which is pretty confusing.

Looks like emacs magit uses %x0C to insert form feeds as separators when running git log. Maybe edamagit could too?
@kahole kahole added the bug Something isn't working label Feb 21, 2022
@max-sixty
Copy link
Sponsor

In particular, this hides any commit coming from dependabot...

grgar added a commit to grgars/edamagit that referenced this issue Apr 24, 2024
@grgar
Support [] in author name (fix kahole#197)
25f7b98 
Fix kahole#197 by supporting [] and […] in author name (e.g. `renovate[bot]`)

Also switch to named groups in regex for easier maintenance.
@grgar grgar linked a pull request Apr 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support [] in author name (fix #197) grgars/edamagit
3 participants
@glasser @max-sixty @kahole