Do not configure BlueField NICs in DPU mode #816
Conversation
|
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
Pull Request Test Coverage Report for Build 12629341153Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
pkg/vendors/mellanox/mellanox.go
Outdated
| log.Log.V(2).Info("mellanox-plugin: configFW(): can't get DPU mode for NIC", "pciAddress", pciAddr) | ||
| } | ||
| if bfMode == BluefieldDpu { | ||
| return errors.Errorf("NIC %s is in DPU mode", pciAddr) |
There was a problem hiding this comment.
can you elaborate that firmware configuration changes are not supported in this case as part of the error message ?
also add a comment saying why (because reboot will not re-load firmware) and that a possible solution is to use mstfwreset b4 reboot
There was a problem hiding this comment.
we need to document that carefully as we have the fwreset feature we implement in the operator but that is not to switch the BF card mode
Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
| log.Log.V(2).Info("mellanox-plugin: configFW(): can't get DPU mode for NIC", "pciAddress", pciAddr) | ||
| } | ||
| if bfMode == BluefieldDpu { | ||
| // Host reboot won't re-load NIC firmware in DPU mode. To apply FW changes power cycle is required or mstfwreset could be used. |
There was a problem hiding this comment.
base on this comment should we allow the configuration if the fwreset feature gate is enabled?
Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
Fixes #662