K3s Additional Build Capabilities #5924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
well as the ability to update the artifact names.
Signed-off-by: Brian Downs <[email protected]>
rbrtbnfgl
previously approved these changes
Aug 1, 2022
dereknola
previously approved these changes
Aug 1, 2022
briandowns
changed the title
brandond
requested changes
Aug 1, 2022
Signed-off-by: Brian Downs <[email protected]>
brandond
approved these changes
Aug 1, 2022
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
brandond
reviewed
Aug 5, 2022
Signed-off-by: Brian Downs <[email protected]>
brandond
requested changes
Aug 5, 2022
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
|
Will squash merge. |
galal-hussein
previously approved these changes
Aug 11, 2022
brandond
requested changes
Aug 15, 2022
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
brandond
requested changes
Aug 16, 2022
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Co-authored-by: Brad Davidson <[email protected]>
brandond
requested changes
Aug 16, 2022
Co-authored-by: Brad Davidson <[email protected]>
brandond
approved these changes
Aug 16, 2022
briandowns
dismissed stale reviews from galal-hussein, dereknola, and rbrtbnfgl
via
985e5e3
|
@briandowns can we close this PR, or is there sections that are still relevant and need to be rebased? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5924 +/- ##
=========================================
- Coverage 9.81% 9.72% -0.10%
=========================================
Files 136 138 +2
Lines 9960 10060 +100
=========================================
Hits 978 978
- Misses 8783 8883 +100
Partials 199 199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
These changes allow for the easier manipulation of the build and build artifacts.
Types of Changes
Verification
Testing
Linked Issues
User-Facing Change
Further Comments