Set User in k3s systemd unit to fix loading AWS shared credentials files #11777
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the $HOME and $USER env vars get set. We have worked around this on the RKE2 side by setting it manually in the default .env file: https://github.com/rancher/rke2/blob/master/bundle/lib/systemd/system/rke2-server.env This is required for loading credentials from shared credentials files (`/root/.aws/credentials`) Signed-off-by: Brad Davidson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11777 +/- ##
==========================================
- Coverage 47.66% 41.36% -6.30%
==========================================
Files 206 206
Lines 19519 19519
==========================================
- Hits 9304 8075 -1229
- Misses 8874 10223 +1349
+ Partials 1341 1221 -120
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This ensures that the $HOME and $USER env vars get set. We have worked around this on the RKE2 side by setting it manually in the default .env file: https://github.com/rancher/rke2/blob/master/bundle/lib/systemd/system/rke2-server.env
This is required for loading credentials from shared credentials files (
/root/.aws/credentials)Ref: https://www.freedesktop.org/software/systemd/man/latest/systemd.exec.html#%24USER
Types of Changes
bugfix
Verification
See instructions in #11614
Testing
yes, install script tests
Linked Issues
User-Facing Change
Further Comments