Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UpdateCLI] Only bump trivy on the minor release #11773

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Feb 11, 2025

Proposed Changes

  • Reduce the frequency of trivy bump (the internal image inside the build, not the GHA version). Only bump on the minors, not patches. We should possibly consider removing this in the future as we have better exposure to trivy scans in other CI areas now.

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner February 11, 2025 21:58
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.78%. Comparing base (04ed6c0) to head (67b8314).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11773      +/-   ##
==========================================
- Coverage   47.58%   46.78%   -0.80%     
==========================================
  Files         206      206              
  Lines       19483    19519      +36     
==========================================
- Hits         9271     9132     -139     
- Misses       8829     9062     +233     
+ Partials     1383     1325      -58     
Flag Coverage Δ
e2etests 40.36% <ø> (-0.93%) ⬇️
inttests 34.99% <ø> (+0.02%) ⬆️
unittests 16.43% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 26b4243 into k3s-io:master Feb 12, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants