Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test/DNM] go.mod: try stock runc version #11722

Closed
wants to merge 1 commit into from

Conversation

kolyshkin
Copy link
Contributor

This is to see how windows compile is broken
(see opencontainers/runc#4616).

FOR TESTING ONLY; DO NOT MERGE.

Proposed Changes

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

This is to see how windows compile is broken
(see opencontainers/runc#4616).

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin
Copy link
Contributor Author

@brandond It's strange but apparently it compiles just fine on Windows with stock runc, meaning the change at k3s-io/runc@688fdd8 is not really needed.

Ah! I found it. By the way, here is the original windows builld error: ttps://drone-pr.k3s.io/k3s-io/k3s/8400/1/4. It comes from k8s.io/pkg/kubelet which imports runc/libcontainer/userns from runc v.1.1.12.

The same issue was fixed in k8s in a different manner: kubernetes/kubernetes@2e999ff (PR kubernetes/kubernetes#122652). This is k8s v1.30; from what I see, older k8s branches (1.29, 1.28, ...) never updated to runc > 1.1.10.

Also, runc itself split the internal part of userns functionality into a separate package here: opencontainers/runc#4331 (made its way to runc v1.2.0, was not backported to any 1.1.x).

Finally, the RunningInUserNS functionality was moved out of runc and into https://github.com/moby/sys (userns package) here: opencontainers/runc#4350, moby/sys#140, moby/sys#145. This is also in runc 1.2 and not backported to older releases.

So, to summarize, the fix (like k3s-io/runc@163700f) is not needed since runc v1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant