Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an HRule class #3

Open
jwodder opened this issue Dec 2, 2021 · 0 comments
Open

Add an HRule class #3

jwodder opened this issue Dec 2, 2021 · 0 comments
Labels
c:borders-rules enhancement New feature or request therefor library API Relating to the public library API

Comments

@jwodder
Copy link
Owner

jwodder commented Dec 2, 2021

Add an "HRule" class that can be passed in place of a data row to indicate that a horizontal rule should be inserted there in the resulting table.

  • HRule constructor arguments (all keyword-only):

    • fill: Optional[str] = None
    • joint: Optional[str] = None
    • left_cap: Optional[str] = None
    • right_cap: Optional[str] = None
    • border_style: Optional[BorderStyle] = None
      • When specified, border_style is used to fill in the default values for the other parameters. When border_style is None:
        • If fill is None, border_style inherits from the Txtble's row_border (or from border_style if that is not a BorderStyle)
        • If fill is not None, ???
  • Give HRule options for (a) not applying the rule's style to the table border intersections at the ends and (b) not applying the rule's style at column intersections?

    • Somehow give header_border and row_border analogous options?
    • Allow header_border and row_border to be set to HRules?
  • Give HRule options for controlling what happens when adjacent to a top_border, header_border, row_border, or bottom_border (possibilities: *_border takes precedence, HRule takes precedence, draw both)

Some basic test cases for this feature can be found on the feature/hrule branch.

@jwodder jwodder added enhancement New feature or request therefor c:borders-rules labels Dec 2, 2021
@jwodder jwodder added the library API Relating to the public library API label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:borders-rules enhancement New feature or request therefor library API Relating to the public library API
Projects
None yet
Development

No branches or pull requests

1 participant