Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add constraints in smart routing rule configuration #2466

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kanikabansal-juspay
Copy link
Collaborator

@kanikabansal-juspay kanikabansal-juspay commented Mar 13, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR adds validation to prevent:

  • Adding a new rule if an existing rule is empty.
  • Copying a rule if the selected rule is empty.
Screen.Recording.2025-03-13.at.2.46.02.PM.mov

Motivation and Context

This ensures data integrity, prevents invalid configurations, and enhances user experience.

How did you test it?

Locally

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

Sorry, something went wrong.

@kanikabansal-juspay kanikabansal-juspay requested a review from a team as a code owner March 13, 2025 10:29
Copy link

Review changes with  SemanticDiff

@kanikabansal-juspay kanikabansal-juspay self-assigned this Mar 13, 2025
@kanikabansal-juspay kanikabansal-juspay added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-feature Category: Feature request or enhancement labels Mar 13, 2025
@kanikabansal-juspay kanikabansal-juspay changed the title chore: Add constraints in smart routing rule configuration refactor: Add constraints in smart routing rule configuration Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] Add validations to not have invalid rule configurations in smart routing
1 participant