-
-
Notifications
You must be signed in to change notification settings - Fork 450
Make Jupyter AI a metapackage #1494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dlqqq
Thanks for working on this. Local build for me is failing at the moment python -m build, it could be related to the front end extension source missing, we will need to add an empty FE extension or figure how to make python only extensions work with releaser.
0bcd5a0 to
d0dcd71
Compare
|
|
|
Figured out how to get Jupyter Releaser to skip the NPM release. Needed to remove all references to the JupyterLab labextension in See these logs from the |
|
@3coins Thanks for the feedback. Removing the labextension-related portions of |
|
This PR is pretty much ready! Just verified that @Zsailer Right now, this PR lacks version range specifiers on the subpackages. I remember you had some thoughts on this topic. Should we just add version floors without ceilings, or should we use both floors & ceilings to ensure users always get a stable experience? cc @ellisonbg |
|
It would be nice to be able to test it out on Bidner. |
|
@dlqqq I would recommend putting floors and no ceilings for now. Let's see how that works and adjust if issues arise. |
|
Thanks, I've added version floors. Still waiting on some changes to As for Binder support, I'm not sure how to set that up, but I can make a note of this to explore after JupyterCon. |
Description
Implements #1495. See the pinned issue for more information.
Code changes
Makes Jupyter AI a metapackage, a blank package that exclusively lists other packages as dependencies which form a functional AI extension when installed together.
User-facing changes
None expected.
Backwards-incompatible changes
All developer APIs are now provided by subpackages. See the subpackages under
jupyter-ai-contrib/for more information.