Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo: Fix MUI theme in Jupyter AI Settings #1213

Closed
wants to merge 1 commit into from

Conversation

dlqqq
Copy link
Member

@dlqqq dlqqq commented Jan 21, 2025

Description

  • A proposed alternative implementation to PR Fix MUI theme in Jupyter AI Settings #1210 (thank you @MUFFANUJ for taking the initiative on this!)
  • Closes Jupyter AI Settings theming is broken #1175.
  • Uses the existing JlThemeProvider React context provider to style the JAI settings page. This is a wrapper around Material UI's ThemeProvider context provider, which automatically styles all MUI components passed as children. This component was implemented in v2, but its use was dropped by accident during the initial v2 => v3 migration.

Demo

Screen.Recording.2025-01-21.at.2.08.56.PM.mov

@dlqqq dlqqq added the bug Something isn't working label Jan 21, 2025
@dlqqq dlqqq marked this pull request as draft January 21, 2025 22:34
@dlqqq dlqqq changed the title Fix MUI theme in Jupyter AI Settings Demo: Fix MUI theme in Jupyter AI Settings Jan 22, 2025
@dlqqq
Copy link
Member Author

dlqqq commented Jan 22, 2025

Closing in favor of #1210.

@dlqqq dlqqq closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jupyter AI Settings theming is broken
1 participant