-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 4.0.0 breaks JupyterLite support #82
Comments
The latest version is now using the From the demo 1258 you are linking I see the tours are working. I guess the fix should be on Lite to implement the handling of the standard config REST endpoint. |
JupyterLite does not implement all the Jupyter Server endpoints (for example there is no
What issue does this cause? |
Hi! I would love to be able to use this again! Is there any news on this issue? |
@EwoutH the latest versions of Closing this issue as fixed, but don't hesitate to comment or open a new one if you still have issues, thanks! |
Description
As noticed in jupyterlite/jupyterlite#1258 (comment) and #76 (comment), the new JupyterLab 4 compatible version does not seem to work
Reproduce
For example testing with ReadTheDocs preview for jupyterlite/jupyterlite#1258: https://jupyterlite--1258.org.readthedocs.build/en/1258/_static/lab/index.html
Expected behavior
jupyterlab-tour
was running fine with JupyterLite before.Looks like this might be related to some new server side logic introduced recently in #81? Could this be made optional to keep JupyterLite support?
The text was updated successfully, but these errors were encountered: