Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

singleuser.extraFiles should allow for referencing secrets/configmaps #3577

Closed
Spazzy757 opened this issue Nov 19, 2024 · 2 comments
Closed

Comments

@Spazzy757
Copy link

Proposed change

Currently we have to inject some secret information into each SingleUser container (i.e ssh private keys, credential files etc), by using "extraFiles" setup this keeps all this information in plaintext and available. There should be a way to be able to store this information in a secret/configmap outside of the helm instalation

Alternative options

Potentially we can do this with an initContainer, however this seems slightly excessive.

Who would use this feature?

Anybody that needs to setup a user environment to have access to external servers

(Optional): Suggest a solution

Add a volume mount setup for the extra files that you can reference a secret or configmap. i.e

singleuser:
  extraFiles:
    id_rsa:
      mode: 384
      mountPath: /home/jovyan/.ssh/id_rsa
      remoteRef:
         secretName: xxxx
         key: id_rsa
@consideRatio
Copy link
Member

You can use singleuser.extraVilumes and singleuser.extraVolumeMounts for this though right? I figure mixing this into extraFiles is messier than needed with those options available as well

@Spazzy757
Copy link
Author

😆 okay that is very valid, and makes sense, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants