Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the addition of a ServiceAccount to the PrePuller #3439

Closed
samyuh opened this issue Jun 20, 2024 · 3 comments
Closed

Allow the addition of a ServiceAccount to the PrePuller #3439

samyuh opened this issue Jun 20, 2024 · 3 comments

Comments

@samyuh
Copy link
Contributor

samyuh commented Jun 20, 2024

Proposed change

The current daemonset configuration does not permit the specification of a ServiceAccount.

Alternative options

One alternative is to allow the assignment of a custom label. However, this is not an ideal solution because our goal is for all pods to have an associated ServiceAccount.

Who would use this feature?

This feature is necessary for everyone who want to deploy pods with a ServiceAccount.

@samyuh
Copy link
Contributor Author

samyuh commented Jun 20, 2024

@samyuh
Copy link
Contributor Author

samyuh commented Jun 21, 2024

Fixed this issue on the following pull request: #3441

Can someone take a look? @minrk

@samyuh
Copy link
Contributor Author

samyuh commented Jun 23, 2024

I will close this issue since this is more likely a bug

@samyuh samyuh closed this as completed Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant