Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with the littlest jupyterhub #32

Closed
minrk opened this issue Jan 11, 2019 · 4 comments
Closed

Test with the littlest jupyterhub #32

minrk opened this issue Jan 11, 2019 · 4 comments

Comments

@minrk
Copy link
Member

minrk commented Jan 11, 2019

Perhaps before we go all the way to kubernetes in #26, we should try using this in the littlest jupyterhub. TLJH is a small, single-machine JupyterHub installation that already includes traefik as an edge proxy (pretty much just for letsencrypt support), in addition to configurable-http-proxy. We could use this traefik-proxy to eliminate the extra configurable-http-proxy service and use only traefik.

What it will look like:

  1. remove configurable-http-proxy
  2. traefik is already launched by systemd (not by TraefikProxy.start() here, so no 'static configuration' would be loaded from the code in this repo), so static config would have to be created in tljh.
  3. probably use the toml implementation in TraefikTomlProxy #31. Alternately, we would need to add and run an etcd service
@GeorgianaElena
Copy link
Member

@minrk, I've added new commits addressing your comments in the PR opened on tljh, if you want to take a look.

@GeorgianaElena
Copy link
Member

@minrk, there's the test_long_username that fails intermittently in tljh.
From the logs it seems that the timeout to wait for a route (20s currently) ends before the route is actually added. Assuming is not something else, I believe it would be good to increase this timeout since we are dealing with I/O operations. Do you agree?

@minrk
Copy link
Member Author

minrk commented Feb 20, 2019

Yeah, go ahead and increase the timeout on the test to see if it helps.

@GeorgianaElena
Copy link
Member

@minrk, thanks a lot for solving the issues with the credentials. Everything seems to work now 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants