-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is the plan to release traefik v2 support #164
Comments
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
Hopefully soon. I think we've done most of the changes we need to. The big outstanding issues are #155 and #151, neither of which need to be addressed before a release with what we have so far. I think we should probably finish #163, so we have a sense of our current situation re: performance, because when I try to stress the current branch I get lots of timeouts and failures (CHP can handle far more transactions than traefik without failure). Do you happen to use etcd or consul for your traefik deployment? |
Hi @minrk But during we test it, have met an issue. The Traefik proxy already get the response from traefik api, but it throw the error. I know the http://:8000 is default value, but I have tried several attribute, still can't change it. **c.Jupyterhub.proxy_class = "traefik_etcd" c.TraefikEtcdPorxy.etcd_url= "http://etcd:2379" Any suggestions for it? |
The problem fixed, we have to setup In the traefik-proxy, it will use it to validate the entries response from traefik. |
Yeah, I'm not sure we should be doing that check when traefik is run externally. I'll look into that. |
If you'd like to test it, 1.0.0b1 is published: https://pypi.org/project/jupyterhub-traefik-proxy/1.0.0b1/ |
So been hoping to see a version of this for traefik v2 for a while, wanted to test it out, running pypi pre-release version:
Following externally managed instructions from here: Running jupyter in a vscode container with exposed port 9000 for jupyterhub to run on, but also why the paths dont match, but they are mapped in correctly Simple jupyterhub config:
traefik config:
It seems to generate some of the dynamic config in jupyter.toml:
Any idea whats generating the error above? |
@alleny87 thanks for testing! Can you run jupyterhub with If the Hub and treafik are running in different containers, you do need to make sure that they are listening on public ips within the container, and connecting to hostnames connectable from other containers (typically the container name). The two relevant config values are: # make sure the Hub is accessible from other containers
c.JupyterHub.hub_bind_url = 'http://:8000'
# tell the hub where the proxy is
c.TraefikProxy.traefik_api_url = 'http://treafik-container-name:8099' Also try disabling subdomain_host for now, as that adds complications to the routing while debugging.
My guess is it's the use of localhost, since the URLs don't appear to have been configured. The 'SSL' part is a mistake in our log messages, since I didn't realize OSErrors could occur here without SSL set up, but the important part is 'cannot assign requested address', which seems weird to me in a connect call, but seems common in docker when connecting to localhost that shouldn't be used for some reason. |
Adding a rule to traefik to filter both localhost and 127.0.0.1 for the api@internal service resolved the
error for me (using Traefik 2.9.8 and Proxy 1.0.0b2). That is:
|
Thanks for testing and reporting back! |
1.0 is out! |
The latest release tag still be 0.3.0, only support traefik v1.7
I saw there are lots of change to support latest Traefik v2 and etcd v3. So when is the plan for next version release ?
Thanks
The text was updated successfully, but these errors were encountered: