Skip to content

Commit 5a2ec9e

Browse files
committed
Don't fail silently when integration-test commands fail
This will lead to tests reported as passing even when they are actually failing.
1 parent 8b2980a commit 5a2ec9e

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

.circleci/integration-test.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,7 @@ def run_container_command(container_name, cmd):
5757
'docker', 'exec',
5858
'-it', container_name,
5959
'/bin/bash', '-c', cmd
60-
])
61-
62-
if proc.returncode != 0:
63-
# Don't throw if command fails. This lets us continue next parts
64-
# of tests. Not entirely sure this is the right thing to do though!
65-
print(f'command {cmd} exited with return code {proc.returncode}')
60+
], check=True)
6661

6762

6863
def copy_to_container(container_name, src_path, dest_path):

0 commit comments

Comments
 (0)