Skip to content

Commit 27cf17d

Browse files
authored
Merge pull request #1041 from jrdnbradford/fixme-req-url
Installer `FIXME`: Only warn on failed install from requirements url
2 parents ca25444 + da5a5ab commit 27cf17d

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

tljh/installer.py

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -293,12 +293,16 @@ def ensure_user_environment(user_requirements_txt_file):
293293
)
294294

295295
if user_requirements_txt_file:
296-
# FIXME: This currently fails hard, should fail soft and not abort installer
297-
conda.ensure_pip_requirements(
298-
USER_ENV_PREFIX,
299-
user_requirements_txt_file,
300-
upgrade=True,
301-
)
296+
try:
297+
conda.ensure_pip_requirements(
298+
USER_ENV_PREFIX,
299+
user_requirements_txt_file,
300+
upgrade=True,
301+
)
302+
except Exception as e:
303+
logger.warning(
304+
f"Failed to install requirements for user env from {user_requirements_txt_file}: {e}"
305+
)
302306

303307

304308
def ensure_admins(admin_password_list):
@@ -530,7 +534,7 @@ def main():
530534
ensure_admins(args.admin)
531535
ensure_usergroups()
532536
if args.user_requirements_txt_url:
533-
logger.info("installing packages from user_requirements_txt_url")
537+
logger.info("Installing packages from user_requirements_txt_url")
534538
ensure_user_environment(args.user_requirements_txt_url)
535539

536540
logger.info("Setting up JupyterHub...")

0 commit comments

Comments
 (0)