We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BinderHub frontend UI migrated to vanilla HTML to React based app in jupyterhub/binderhub#1856. Because of this, the test
mybinder.org-deploy/tests/test_federation_redirect.py
Lines 13 to 16 in 6e2a0e2
The "simplest" solution is to replace assert to check for
<div id="root"></div>
from https://github.com/jupyterhub/binderhub/blob/65f807c12c61aed2179293d1bd0f72d117e92793/binderhub/templates/page.html#L24. In this simplest solution will don't need to run the JavaScript. We only check that the React based app has a HTML anchor.
Alternatively, the assert can be replaced with a solution powered by an automation library for browser testing like
The text was updated successfully, but these errors were encountered:
Re-write test_proxy_page() the simplest way possible
160a9e1
Related to jupyterhub#3188
In #3189 (comment), @minrk suggested to use Playwright.
The continuous deployment run the test at
mybinder.org-deploy/.github/workflows/cd.yml
Lines 182 to 188 in c46ce00
A couple of more steps documented at https://playwright.dev/python/docs/ci#github-actions will need to be added before the tests start.
Sorry, something went wrong.
No branches or pull requests
BinderHub frontend UI migrated to vanilla HTML to React based app in jupyterhub/binderhub#1856. Because of this, the test
mybinder.org-deploy/tests/test_federation_redirect.py
Lines 13 to 16 in 6e2a0e2
The "simplest" solution is to replace assert to check for
from https://github.com/jupyterhub/binderhub/blob/65f807c12c61aed2179293d1bd0f72d117e92793/binderhub/templates/page.html#L24. In this simplest solution will don't need to run the JavaScript. We only check that the React based app has a HTML anchor.
Alternatively, the assert can be replaced with a solution powered by an automation library for browser testing like
The text was updated successfully, but these errors were encountered: