Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validete profile_list with JSON Schema #736

Open
yuvipanda opened this issue May 18, 2023 · 0 comments
Open

Validete profile_list with JSON Schema #736

yuvipanda opened this issue May 18, 2023 · 0 comments

Comments

@yuvipanda
Copy link
Collaborator

With us adding more options to profile_list, it's growing in complexity. We should validate it with JSON schema like we do with OAuthenticator here: https://github.com/jupyterhub/oauthenticator/blob/921824c02cc9c256674b7daecf481ca67de7c5a0/oauthenticator/cilogon.py#L179

One option is to add a JSONSchemaValidatedDict or similar to the upstream traitlets package and use that. Alternatively, we can just replicate the pattern from OAuthenticator here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yuvipanda