From 229ae3c52ce0ff1463b98bf3274d18bce2960f77 Mon Sep 17 00:00:00 2001
From: Min RK <benjaminrk@gmail.com>
Date: Wed, 2 Oct 2024 11:44:21 +0200
Subject: [PATCH] more exercise of unsafe names in integration tests

---
 kubespawner/spawner.py |  2 +-
 tests/test_spawner.py  | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/kubespawner/spawner.py b/kubespawner/spawner.py
index 023d6869..306f9be5 100644
--- a/kubespawner/spawner.py
+++ b/kubespawner/spawner.py
@@ -165,7 +165,7 @@ def __init__(self, *args, **kwargs):
             # runs during test execution only
             if 'user' not in kwargs:
                 user = MockObject()
-                user.name = 'mock_name'
+                user.name = 'mock@name'
                 user.id = 'mock_id'
                 user.url = 'mock_url'
                 self.user = user
diff --git a/tests/test_spawner.py b/tests/test_spawner.py
index 453ae1ca..c91e5961 100644
--- a/tests/test_spawner.py
+++ b/tests/test_spawner.py
@@ -27,7 +27,7 @@
 
 
 class MockUser(Mock):
-    name = 'fake'
+    name = '9user@email.com'
     server = Server()
 
     def __init__(self, **kwargs):
@@ -272,7 +272,7 @@ async def test_spawn_start_in_different_namespace(
 async def test_spawn_enable_user_namespaces():
     user = MockUser()
     spawner = KubeSpawner(user=user, _mock=True, enable_user_namespaces=True)
-    assert spawner.namespace.endswith(f"-{user.escaped_name}")
+    assert spawner.namespace.endswith(f"-{safe_slug(user.name)}")
 
 
 async def test_spawn_start_enable_user_namespaces(
@@ -289,7 +289,7 @@ async def test_spawn_start_enable_user_namespaces(
 
     spawner = KubeSpawner(
         hub=hub,
-        user=MockUser(name="start"),
+        user=MockUser(name="start@test"),
         config=config,
         api_token="abc123",
         oauth_client_id="unused",
@@ -1625,7 +1625,7 @@ async def test_pod_connect_ip(kube_ns, kube_client, config, hub_pod, hub):
 async def test_get_pvc_manifest():
     c = Config()
 
-    username = "mock_name"
+    username = "mock@name"
     slug = safe_slug(username)
     c.KubeSpawner.pvc_name_template = "user-{username}"
     c.KubeSpawner.storage_extra_labels = {"user": "{username}"}
@@ -1640,7 +1640,7 @@ async def test_get_pvc_manifest():
     assert manifest.metadata.name == f"user-{slug}"
     assert manifest.metadata.labels == {
         "user": slug,
-        "hub.jupyter.org/username": username,
+        "hub.jupyter.org/username": slug,
         "app.kubernetes.io/name": "jupyterhub",
         "app.kubernetes.io/managed-by": "kubespawner",
         "app.kubernetes.io/component": "singleuser-server",