-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to aiohttp for requests in jupyterhub's cull_idle_servers #53
Comments
Hi! My name is Sasha, I'm an Outreachy applicant, and I would like to work on this task. |
@religofsil great! Feel free to ask further questions here or on gitter. The place to start is getting set up with a local install of jupyterhub. |
@religofsil have you made any progress on this? Feel free to stop by gitter or ask questions here if you have them. If we don't hear from you in a couple of days, we will reopen this issue so other applicants can look at it. |
Hey @minrk @religofsil . If no one is taking up the issue, I would like to work on this. |
@minrk sorry, I was just reading the documentation on aiohttp and on asynchronous python, and got a bit lost, but I'm working on it! |
@religofsil no problem, just checking in! Feel free to ask questions here or in Gitter. |
@religofsil are you still working on this one? If not, I'd like to make it available to other applicants. If so, that's fine, too! Feel free to ask questions if you need help. |
Yes, I am! Sorry it's taking so long. :( |
No worries! Please feel free to ask questions here or on Gitter if you get stuck. |
@religofsil Hey, I would like to help in this issue. Kindly, let me know if I could work on this |
While the description is outdated @minrk, the issue seems relevant still. Right? See https://github.com/jupyterhub/jupyterhub-idle-culler/blob/main/jupyterhub_idle_culler/__init__.py |
@consideRatio that's true! |
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
@minrk and @consideRatio, I've moved the issue in this repository to not create confusion around the this year's Outreachy projects. Plus, I believe it has more visibility here. |
JupyterHub uses tornado's httpclient to make requests internally. We would like to switch to using aiohttp instead.
Tasks:
AsyncHTTPClient
in the scriptaiohttp
Remember, you don't need to already know how to do all this! We'll help you. Respond to the issue here if you have questions :)
The text was updated successfully, but these errors were encountered: